Changed: Minor changes

This commit is contained in:
kervala 2014-12-26 13:38:02 +01:00
parent 1f247f032e
commit 935ee947a6
48 changed files with 78 additions and 100 deletions

View file

@ -493,7 +493,7 @@ public:
* *
* NB: you must setupViewMatrix() BEFORE setupModelMatrix(), or else undefined results. * NB: you must setupViewMatrix() BEFORE setupModelMatrix(), or else undefined results.
*/ */
virtual void setupViewMatrix(const CMatrix &mtx)=0; virtual void setupViewMatrix(const CMatrix &mtx) = 0;
/** setup the view matrix (inverse of camera matrix). /** setup the view matrix (inverse of camera matrix).
* Extended: give a cameraPos (mtx.Pos() is not taken into account but for getViewMatrix()), * Extended: give a cameraPos (mtx.Pos() is not taken into account but for getViewMatrix()),
@ -1422,7 +1422,6 @@ protected:
private: private:
bool _StaticMemoryToVRAM; bool _StaticMemoryToVRAM;
}; };
// -------------------------------------------------- // --------------------------------------------------

View file

@ -39,9 +39,9 @@ class CPThread : public IThread
public: public:
enum TThreadState enum TThreadState
{ {
ThreadStateNone, ThreadStateNone,
ThreadStateRunning, ThreadStateRunning,
ThreadStateFinished, ThreadStateFinished,
}; };
/// Constructor /// Constructor

View file

@ -543,14 +543,14 @@ ColorPickerPopup::ColorPickerPopup(int width, bool withColorDialog,
setMouseTracking(true); setMouseTracking(true);
cols = width; cols = width;
if (withColorDialog) if (withColorDialog)
{ {
moreButton = new ColorPickerButton(this); moreButton = new ColorPickerButton(this);
moreButton->setFixedWidth(24); moreButton->setFixedWidth(24);
moreButton->setFixedHeight(21); moreButton->setFixedHeight(21);
moreButton->setFrameRect(QRect(2, 2, 20, 17)); moreButton->setFrameRect(QRect(2, 2, 20, 17));
connect(moreButton, SIGNAL(clicked()), SLOT(getColorFromDialog())); connect(moreButton, SIGNAL(clicked()), SLOT(getColorFromDialog()));
} }
else else
{ {
moreButton = 0; moreButton = 0;

View file

@ -1509,9 +1509,6 @@ bool CDriverD3D::setDisplay(nlWindow wnd, const GfxMode& mode, bool show, bool r
} }
} }
// _D3D->CreateDevice (adapter, _Rasterizer, _HWnd, D3DCREATE_SOFTWARE_VERTEXPROCESSING, &parameters, &_DeviceInterface);
// Check some caps // Check some caps
D3DCAPS9 caps; D3DCAPS9 caps;
if (_DeviceInterface->GetDeviceCaps(&caps) == D3D_OK) if (_DeviceInterface->GetDeviceCaps(&caps) == D3D_OK)

View file

@ -2178,7 +2178,7 @@ void CDriverGL::flush()
// *************************************************************************** // ***************************************************************************
void CDriverGL::setSwapVBLInterval(uint interval) void CDriverGL::setSwapVBLInterval(uint interval)
{ {
H_AUTO_OGL(CDriverGL_setSwapVBLInterval) H_AUTO_OGL(CDriverGL_setSwapVBLInterval);
if (!_Initialized) if (!_Initialized)
return; return;

View file

@ -403,7 +403,7 @@ bool CDriverGL::setupMaterial(CMaterial& mat)
// Must setup textures each frame. (need to test if touched). // Must setup textures each frame. (need to test if touched).
// Must separate texture setup and texture activation in 2 "for"... // Must separate texture setup and texture activation in 2 "for"...
// because setupTexture() may disable all stage. // because setupTexture() may disable all stage.
if (matShader != CMaterial::Water if (matShader != CMaterial::Water
&& ((matShader != CMaterial::Program) || (_LastSetuppedPP->features().MaterialFlags & CProgramFeatures::TextureStages)) && ((matShader != CMaterial::Program) || (_LastSetuppedPP->features().MaterialFlags & CProgramFeatures::TextureStages))
) )
{ {

View file

@ -767,7 +767,7 @@ void CDriverGLStates::setTextureMode(TTextureMode texMode)
{ {
glDisable(GL_TEXTURE_2D); glDisable(GL_TEXTURE_2D);
} }
else if(oldTexMode == TextureRect) else if (oldTexMode == TextureRect)
{ {
#ifndef USE_OPENGLES #ifndef USE_OPENGLES
if(_TextureRectangleSupported) if(_TextureRectangleSupported)
@ -780,7 +780,7 @@ void CDriverGLStates::setTextureMode(TTextureMode texMode)
glDisable(GL_TEXTURE_2D); glDisable(GL_TEXTURE_2D);
} }
} }
else if(oldTexMode == TextureCubeMap) else if (oldTexMode == TextureCubeMap)
{ {
if(_TextureCubeMapSupported) if(_TextureCubeMapSupported)
{ {

View file

@ -392,7 +392,6 @@ bool CMeshVPWindTree::begin(IDriver *driver, CScene *scene, CMeshBaseInstance *m
sint numPls= renderTrav->getNumVPLights()-1; sint numPls= renderTrav->getNumVPLights()-1;
clamp(numPls, 0, CRenderTrav::MaxVPLight-1); clamp(numPls, 0, CRenderTrav::MaxVPLight-1);
// Enable normalize only if requested by user. Because lighting don't manage correct "scale lighting" // Enable normalize only if requested by user. Because lighting don't manage correct "scale lighting"
uint idVP= (SpecularLighting?2:0) + (driver->isForceNormalize()?1:0) ; uint idVP= (SpecularLighting?2:0) + (driver->isForceNormalize()?1:0) ;
// correct VP id for correct unmber of pls. // correct VP id for correct unmber of pls.
@ -523,7 +522,7 @@ void CMeshVPWindTree::beginMBRInstance(IDriver *driver, CScene *scene, CMeshBase
idVP = numPls*4 + idVP; idVP = numPls*4 + idVP;
// re-activate VP if idVP different from last setup // re-activate VP if idVP different from last setup
if(idVP != _LastMBRIdVP) if (idVP != _LastMBRIdVP)
{ {
_LastMBRIdVP= idVP; _LastMBRIdVP= idVP;
driver->activeVertexProgram(_VertexProgram[_LastMBRIdVP]); driver->activeVertexProgram(_VertexProgram[_LastMBRIdVP]);

View file

@ -158,7 +158,7 @@ CScene::CScene(bool bSmallScene) : LightTrav(bSmallScene)
_MaxSkeletonsInNotCLodForm= 20; _MaxSkeletonsInNotCLodForm= 20;
_FilterRenderFlags= std::numeric_limits<uint32>::max(); _FilterRenderFlags = std::numeric_limits<uint32>::max();
_NextRenderProfile= false; _NextRenderProfile= false;
@ -592,11 +592,9 @@ void CScene::renderPart(UScene::TRenderPart rp, bool doHrcPass, bool doTrav, boo
// //
nlassert(CurrentCamera); nlassert(CurrentCamera);
// update models. // update models.
updateModels(); updateModels();
// Use the camera to setup Clip / Render pass. // Use the camera to setup Clip / Render pass.
float left, right, bottom, top, znear, zfar; float left, right, bottom, top, znear, zfar;
CurrentCamera->getFrustum(left, right, bottom, top, znear, zfar); CurrentCamera->getFrustum(left, right, bottom, top, znear, zfar);

View file

@ -244,7 +244,7 @@ void CShadowMapManager::addShadowReceiver(CTransform *model)
void CShadowMapManager::renderGenerate(CScene *scene) void CShadowMapManager::renderGenerate(CScene *scene)
{ {
H_AUTO( NL3D_ShadowManager_Generate ); H_AUTO( NL3D_ShadowManager_Generate );
// Each frame, do a small garbage collector for unused free textures. // Each frame, do a small garbage collector for unused free textures.
garbageShadowTextures(scene); garbageShadowTextures(scene);

View file

@ -113,7 +113,7 @@ CTransform::CTransform()
_StateFlags= IsOpaque | IsUserLightable; _StateFlags= IsOpaque | IsUserLightable;
// By default, always allow rendering of Transform Models. // By default, always allow rendering of Transform Models.
_RenderFilterType= std::numeric_limits<uint32>::max(); _RenderFilterType = std::numeric_limits<uint32>::max();
// By default, don't suport fast intersection detection // By default, don't suport fast intersection detection
_SupportFastIntersect= false; _SupportFastIntersect= false;

View file

@ -707,7 +707,7 @@ bool CFormDfn::getEntryIndexByName (uint &entry, const std::string &name) const
} }
entryIndex++; entryIndex++;
} }
entry=std::numeric_limits<uint>::max(); entry = std::numeric_limits<uint>::max();
return false; return false;
} }

View file

@ -17,8 +17,8 @@
#include "stdmisc.h" #include "stdmisc.h"
#include <nel/misc/types_nl.h> #include "nel/misc/types_nl.h"
#include <nel/misc/debug.h> #include "nel/misc/debug.h"
#ifdef NL_OS_UNIX #ifdef NL_OS_UNIX

View file

@ -217,7 +217,7 @@ bool CSheetId::buildSheetId(const std::string& sheetName)
return true; return true;
} }
} }
#ifdef NL_TEMP_YUBO_NO_SOUND_SHEET_ID #ifdef NL_TEMP_YUBO_NO_SOUND_SHEET_ID
if (a_NoSoundSheetId && sheetName.find(".sound") != std::string::npos) if (a_NoSoundSheetId && sheetName.find(".sound") != std::string::npos)
{ {
@ -236,7 +236,7 @@ bool CSheetId::buildSheetId(const std::string& sheetName)
return true; return true;
} }
#endif #endif
return false; return false;
} }
@ -417,10 +417,10 @@ void CSheetId::initWithoutSheet()
nlassert(_DontHaveSheetKnowledge); nlassert(_DontHaveSheetKnowledge);
return; return;
} }
_Initialised = true; _Initialised = true;
_DontHaveSheetKnowledge = true; _DontHaveSheetKnowledge = true;
// Initialize id 0,0 as unknown.unknown // Initialize id 0,0 as unknown.unknown
CSheetId unknownunknown = CSheetId("unknown.unknown"); CSheetId unknownunknown = CSheetId("unknown.unknown");
nlassert(unknownunknown == CSheetId::Unknown); nlassert(unknownunknown == CSheetId::Unknown);
@ -525,7 +525,7 @@ bool CSheetId::operator < (const CSheetId& sheetRef ) const
string CSheetId::toString(bool ifNotFoundUseNumericId) const string CSheetId::toString(bool ifNotFoundUseNumericId) const
{ {
if (!_Initialised) init(false); if (!_Initialised) init(false);
if (_DontHaveSheetKnowledge) if (_DontHaveSheetKnowledge)
{ {
// FIXME: When someone punches in a fake sheet id this will // FIXME: When someone punches in a fake sheet id this will
@ -564,7 +564,7 @@ string CSheetId::toString(bool ifNotFoundUseNumericId) const
void CSheetId::serial(NLMISC::IStream &f) throw(NLMISC::EStream) void CSheetId::serial(NLMISC::IStream &f) throw(NLMISC::EStream)
{ {
nlassert(!_DontHaveSheetKnowledge); nlassert(!_DontHaveSheetKnowledge);
f.serial( _Id.Id ); f.serial( _Id.Id );
#ifdef NL_DEBUG_SHEET_ID #ifdef NL_DEBUG_SHEET_ID

View file

@ -198,7 +198,7 @@ void CWinThread::start ()
{ {
if (isRunning()) if (isRunning())
throw EThread("Starting a thread that is already started, existing thread will continue running, this should not happen"); throw EThread("Starting a thread that is already started, existing thread will continue running, this should not happen");
// ThreadHandle = (void *) ::CreateThread (NULL, _StackSize, ProxyFunc, this, 0, (DWORD *)&ThreadId); // ThreadHandle = (void *) ::CreateThread (NULL, _StackSize, ProxyFunc, this, 0, (DWORD *)&ThreadId);
ThreadHandle = (void *) ::CreateThread (NULL, 0, ProxyFunc, this, 0, (DWORD *)&ThreadId); ThreadHandle = (void *) ::CreateThread (NULL, 0, ProxyFunc, this, 0, (DWORD *)&ThreadId);
// nldebug("NLMISC: thread %x started for runnable '%x'", typeid( Runnable ).name()); // nldebug("NLMISC: thread %x started for runnable '%x'", typeid( Runnable ).name());

View file

@ -80,7 +80,7 @@ enum TSourceDSoundEndState
class CSourceDSound : public ISource class CSourceDSound : public ISource
{ {
friend class CSoundDriverDSound; friend class CSoundDriverDSound;
public: public:
/// Constructor /// Constructor
CSourceDSound(uint sourcename = 0); CSourceDSound(uint sourcename = 0);
@ -446,7 +446,7 @@ private:
// Set the 'used' state of the source. Managed by the driver. // Set the 'used' state of the source. Managed by the driver.
void setUsed(bool v) { _IsUsed = v; } void setUsed(bool v) { _IsUsed = v; }
// Return the 'used' state of the source // Return the 'used' state of the source
bool isUsed() { return _IsUsed; } bool isUsed() { return _IsUsed; }
*/ */

View file

@ -419,7 +419,7 @@ void CSourceFMod::setMinMaxDistances( float mindist, float maxdist, bool /* defe
nlwarning("SOUND_DEV (FMod): Ridiculously high max distance set on source"); nlwarning("SOUND_DEV (FMod): Ridiculously high max distance set on source");
maxdist = maxSqrt; maxdist = maxSqrt;
} }
_MinDist= mindist; _MinDist= mindist;
_MaxDist= maxdist; _MaxDist= maxdist;
if(_FModChannel!=-1) if(_FModChannel!=-1)

View file

@ -121,7 +121,7 @@ bool CBufferAL::unlock(uint size)
// Error handling // Error handling
if (alGetError() == AL_NO_ERROR) if (alGetError() == AL_NO_ERROR)
_IsLoaded = true; // ->lock() set it to false _IsLoaded = true; // ->lock() set it to false
return _IsLoaded; return _IsLoaded;
} }
@ -162,7 +162,7 @@ bool CBufferAL::fill(const uint8 *src, uint size)
// Error handling // Error handling
_IsLoaded = (alGetError() == AL_NO_ERROR); _IsLoaded = (alGetError() == AL_NO_ERROR);
return _IsLoaded; return _IsLoaded;
} }

View file

@ -176,7 +176,7 @@ void CSimpleSource::play()
// and play the sound // and play the sound
bool play = pSource->play(); bool play = pSource->play();
#ifdef NL_DEBUG #ifdef NL_DEBUG
nlassert(play); nlassert(play);
#else #else

View file

@ -1,4 +1,3 @@
# Don't add other subdirectories if only max plugins are selected. # Don't add other subdirectories if only max plugins are selected.
IF(WITH_NEL_TOOLS) IF(WITH_NEL_TOOLS)
ADD_SUBDIRECTORY(misc) ADD_SUBDIRECTORY(misc)

View file

@ -30,8 +30,8 @@
/////////// ///////////
// CLASS // // CLASS //
class CCombo; class CCombo;
class CActionsManager;
class CAction; class CAction;
class CActionsManager;
/** /**
* The goal of CCombo is to gather together Inputs that will validate an Action. * The goal of CCombo is to gather together Inputs that will validate an Action.

View file

@ -41,7 +41,7 @@
#include <string> #include <string>
#include "../../common/src/game_share/ryzom_database_banks.h" #include "game_share/ryzom_database_banks.h"
//////////////// ////////////////

View file

@ -4537,7 +4537,7 @@ void CCharacterCL::applyBehaviourFlyingHPs(const CBehaviourContext &bc, const MB
{ {
if(behaviour.DeltaHP != 0) if(behaviour.DeltaHP != 0)
{ {
CRGBA deltaHPColor( 0, 0, 0 ); CRGBA deltaHPColor(0, 0, 0);
// if it's a hit // if it's a hit
if( behaviour.DeltaHP < 0 ) if( behaviour.DeltaHP < 0 )
{ {

View file

@ -26,7 +26,6 @@
#include "nel/misc/types_nl.h" #include "nel/misc/types_nl.h"
#ifdef NL_OS_WINDOWS #ifdef NL_OS_WINDOWS
#include <windows.h>
#include <shellapi.h> #include <shellapi.h>
#else #else
#include <csignal> #include <csignal>

View file

@ -969,8 +969,6 @@ void CClientChatManager::buildTellSentence(const ucstring &sender, const ucstrin
name = STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(CEntityCL::getTitleFromName(name), bWoman); name = STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(CEntityCL::getTitleFromName(name), bWoman);
} }
} }
} }
else else
{ {
@ -1052,8 +1050,6 @@ void CClientChatManager::buildChatSentence(TDataSetIndex /* compressedSenderInde
senderName = STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(CEntityCL::getTitleFromName(senderName), bWoman); senderName = STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(CEntityCL::getTitleFromName(senderName), bWoman);
} }
} }
} }
switch(type) switch(type)

View file

@ -426,7 +426,7 @@ void CEntityManager::initialize(uint nbMaxEntity)
_Entities.resize(_NbMaxEntity, 0); _Entities.resize(_NbMaxEntity, 0);
_EntityGroundFXHandle.resize(_NbMaxEntity); _EntityGroundFXHandle.resize(_NbMaxEntity);
} }
ICDBNode::CTextId textId; ICDBNode::CTextId textId;
// Add an observer on the mission database // Add an observer on the mission database

View file

@ -2296,6 +2296,7 @@ void CEntityCL::onStringAvailable(uint /* stringId */, const ucstring &value)
} }
ucstring replacement(STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(_TitleRaw, womanTitle)); ucstring replacement(STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(_TitleRaw, womanTitle));
// Sometimes translation contains another title // Sometimes translation contains another title
{ {
ucstring::size_type pos = replacement.find('$'); ucstring::size_type pos = replacement.find('$');
@ -2308,7 +2309,7 @@ void CEntityCL::onStringAvailable(uint /* stringId */, const ucstring &value)
replacement = STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(_TitleRaw, womanTitle); replacement = STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(_TitleRaw, womanTitle);
} }
} }
_Tags = STRING_MANAGER::CStringManagerClient::getTitleInfos(_TitleRaw, womanTitle); _Tags = STRING_MANAGER::CStringManagerClient::getTitleInfos(_TitleRaw, womanTitle);
if (!replacement.empty() || !ClientCfg.DebugStringManager) if (!replacement.empty() || !ClientCfg.DebugStringManager)
@ -2949,7 +2950,7 @@ void CEntityCL::dataSetId(CLFECOMMON::TClientDataSetIndex dataSet)
{ {
_DataSetId = dataSet; _DataSetId = dataSet;
if (_Primitive && _Primitive->UserData == UserDataEntity) if (_Primitive && _Primitive->UserData == UserDataEntity)
_Primitive->UserData |= (((uint64)_DataSetId)<<16); _Primitive->UserData |= (((uint64)_DataSetId)<<16);
// additionaly, on a UID change, must check the IsInTeam and IsAniml flags // additionaly, on a UID change, must check the IsInTeam and IsAniml flags

View file

@ -188,7 +188,6 @@ const std::string& CLoginStateMachine::toString(CLoginStateMachine::TEvent event
_CurrentState = stateId; \ _CurrentState = stateId; \
break; \ break; \
} \ } \
extern std::string LoginLogin, LoginPassword; extern std::string LoginLogin, LoginPassword;
extern bool noUserChar; extern bool noUserChar;

View file

@ -759,7 +759,7 @@ void prelogInit()
NLMISC::CTime::probeTimerInfo(timerInfo); NLMISC::CTime::probeTimerInfo(timerInfo);
if (timerInfo.RequiresSingleCore) // TODO: Also have a FV configuration value to force single core. if (timerInfo.RequiresSingleCore) // TODO: Also have a FV configuration value to force single core.
setCPUMask(); setCPUMask();
FPU_CHECKER_ONCE FPU_CHECKER_ONCE
NLMISC::TTime initStart = ryzomGetLocalTime (); NLMISC::TTime initStart = ryzomGetLocalTime ();
@ -949,7 +949,7 @@ void prelogInit()
Driver->setSwapVBLInterval(1); Driver->setSwapVBLInterval(1);
else else
Driver->setSwapVBLInterval(0); Driver->setSwapVBLInterval(0);
if (StereoDisplay) // VR_CONFIG // VR_DRIVER if (StereoDisplay) // VR_CONFIG // VR_DRIVER
{ {
// override mode TODO // override mode TODO
@ -1077,7 +1077,7 @@ void prelogInit()
// Set the monitor color properties // Set the monitor color properties
CMonitorColorProperties monitorColor; CMonitorColorProperties monitorColor;
for ( uint i=0; i<3; i++) for (uint i=0; i<3; i++)
{ {
monitorColor.Contrast[i] = ClientCfg.Contrast; monitorColor.Contrast[i] = ClientCfg.Contrast;
monitorColor.Luminosity[i] = ClientCfg.Luminosity; monitorColor.Luminosity[i] = ClientCfg.Luminosity;

View file

@ -1950,13 +1950,14 @@ public:
womanTitle = pChar->getGender() == GSGENDER::female; womanTitle = pChar->getGender() == GSGENDER::female;
STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(CEntityCL::getTitleFromName(copyInout), womanTitle); STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(CEntityCL::getTitleFromName(copyInout), womanTitle);
// Sometimes translation contains another title // Sometimes translation contains another title
ucstring::size_type pos = copyInout.find('$'); ucstring::size_type pos = copyInout.find('$');
if (pos != ucstring::npos) if (pos != ucstring::npos)
{ {
copyInout = STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(CEntityCL::getTitleFromName(copyInout), womanTitle); copyInout = STRING_MANAGER::CStringManagerClient::getTitleLocalizedName(CEntityCL::getTitleFromName(copyInout), womanTitle);
} }
CStringPostProcessRemoveTitle::cbIDStringReceived(copyInout); CStringPostProcessRemoveTitle::cbIDStringReceived(copyInout);
inout = copyInout; inout = copyInout;
} }

View file

@ -3613,7 +3613,7 @@ public:
uint8 index; uint8 index;
fromString(Params, index); fromString(Params, index);
--index; // Param is 1-based so subtract 1 --index; // Param is 1-based so subtract 1
if ( index >= MAX_INVENTORY_ANIMAL) if (index >= MAX_INVENTORY_ANIMAL)
{ {
return; return;
} }

View file

@ -520,7 +520,7 @@ CCameraBackup setupCameraForScreenshot(UScene &scene, uint left, uint right, uin
// Build a viewport // Build a viewport
CViewport viewport; CViewport viewport;
NL3D::UDriver *Driver = CViewRenderer::getInstance()->getDriver(); NL3D::UDriver *Driver = CViewRenderer::getInstance()->getDriver();
viewport.init (0, 0, (float)(right-left)/Driver->getWindowWidth(),(float)(bottom-top)/Driver->getWindowHeight()); viewport.init (0, 0, (float)(right-left)/Driver->getWindowWidth(), (float)(bottom-top)/Driver->getWindowHeight());
// Activate all this // Activate all this
scene.getCam().setFrustum (frustumPart); scene.getCam().setFrustum (frustumPart);

View file

@ -777,7 +777,7 @@ void CHandlerMemorizePhraseOrMacro::execute (CCtrlBase *pCaller, const string &P
sint32 dstPhraseId= pCSDst->getSPhraseId(); sint32 dstPhraseId= pCSDst->getSPhraseId();
sint32 dstMacroId= pCSDst->getMacroId(); sint32 dstMacroId= pCSDst->getMacroId();
if ((src.empty()) && (CHandlerPhraseMemoryCopy::haveLastPhraseElement)) if (src.empty() && (CHandlerPhraseMemoryCopy::haveLastPhraseElement))
{ {
// get the slot ids from save // get the slot ids from save
srcIsMacro= CHandlerPhraseMemoryCopy::isMacro; srcIsMacro= CHandlerPhraseMemoryCopy::isMacro;
@ -1600,7 +1600,6 @@ public:
} }
} }
}; };
REGISTER_ACTION_HANDLER(CHandlerPhraseSelectMemory2, "phrase_select_memory_2"); REGISTER_ACTION_HANDLER(CHandlerPhraseSelectMemory2, "phrase_select_memory_2");
// *************************************************************************** // ***************************************************************************

View file

@ -30,7 +30,6 @@
#undef LOG_WARNING #undef LOG_WARNING
#endif #endif
/** /**
* class used to display console text commands in the chat window * class used to display console text commands in the chat window
* \author Nicolas Brigand * \author Nicolas Brigand

View file

@ -47,7 +47,6 @@ CChatTextManager::~CChatTextManager()
_TextShadowed = NULL; _TextShadowed = NULL;
delete _ShowTimestamps; delete _ShowTimestamps;
_ShowTimestamps = NULL; _ShowTimestamps = NULL;
} }
//================================================================================= //=================================================================================
uint CChatTextManager::getTextFontSize() const uint CChatTextManager::getTextFontSize() const
@ -96,6 +95,7 @@ bool CChatTextManager::showTimestamps() const
} }
return _ShowTimestamps->getValueBool(); return _ShowTimestamps->getValueBool();
} }
//================================================================================= //=================================================================================
static CInterfaceGroup *parseCommandTag(ucstring &line) static CInterfaceGroup *parseCommandTag(ucstring &line)
{ {
@ -186,7 +186,6 @@ CViewBase *CChatTextManager::createMsgText(const ucstring &cstMsg, NLMISC::CRGBA
msg = cur_time + msg; msg = cur_time + msg;
} }
vt->setTextFormatTaged(msg); vt->setTextFormatTaged(msg);
vt->setColor(NLMISC::CRGBA::White); vt->setColor(NLMISC::CRGBA::White);
} }

View file

@ -198,7 +198,7 @@ CGroupInSceneUserInfo *CGroupInSceneUserInfo::build (CEntityCL *entity)
ucstring theTribeName; ucstring theTribeName;
ucstring entityName = entity->getDisplayName(); ucstring entityName = entity->getDisplayName();
ucstring entityTitle = entity->getTitle(); ucstring entityTitle = entity->getTitle();
// For some NPC's the name is empty and only a title is given, // For some NPC's the name is empty and only a title is given,
// in that case, treat the title as the name. // in that case, treat the title as the name.
if (entityName.empty()) if (entityName.empty())
@ -652,7 +652,6 @@ CGroupInSceneUserInfo *CGroupInSceneUserInfo::build (CEntityCL *entity)
if (pPlayer == NULL) if (pPlayer == NULL)
needPvPLogo = false; needPvPLogo = false;
if (pPlayer != NULL && needPvPLogo) if (pPlayer != NULL && needPvPLogo)
{ {
if (pvpFactionLogo) if (pvpFactionLogo)
@ -756,7 +755,6 @@ CGroupInSceneUserInfo *CGroupInSceneUserInfo::build (CEntityCL *entity)
view = leftGroup->getView ("win_jauge_bot"); view = leftGroup->getView ("win_jauge_bot");
if (view) if (view)
leftGroup->delView (view); leftGroup->delView (view);
} }
// Delete remaining strings // Delete remaining strings
@ -771,8 +769,7 @@ CGroupInSceneUserInfo *CGroupInSceneUserInfo::build (CEntityCL *entity)
CViewBase *win_mid = leftGroup->getView ("win_mid"); CViewBase *win_mid = leftGroup->getView ("win_mid");
if (win_mid) if (win_mid)
{ {
win_mid->setH (win_mid->getH() - spaceBar/2 ); win_mid->setH (win_mid->getH() - spaceBar/2);
} }
// Set player name // Set player name
@ -963,7 +960,7 @@ void CGroupInSceneUserInfo::updateDynamicData ()
if (pPlayer != NULL) if (pPlayer != NULL)
if (pPlayer->isAFK()) if (pPlayer->isAFK())
entityName += CI18N::get("uiAFK"); entityName += CI18N::get("uiAFK");
_Name->setText(entityName); _Name->setText(entityName);
// Title color get the PVP color // Title color get the PVP color

View file

@ -3213,7 +3213,7 @@ class CAHValidateUserLandMarkName : public IActionHandler
CGroupEditBox *eb = dynamic_cast<CGroupEditBox *>(ig->getGroup("eb")); CGroupEditBox *eb = dynamic_cast<CGroupEditBox *>(ig->getGroup("eb"));
if (!eb) return; if (!eb) return;
ig->setActive(false); ig->setActive(false);
CGroupContainer *gc = dynamic_cast<CGroupContainer *>(CWidgetManager::getInstance()->getElementFromId(WIN_LANDMARK_NAME)); CGroupContainer *gc = dynamic_cast<CGroupContainer *>(CWidgetManager::getInstance()->getElementFromId(WIN_LANDMARK_NAME));
if (!gc) return; if (!gc) return;
// Retrieve ComboBox to get the position(ordered landmark type) of the selected item // Retrieve ComboBox to get the position(ordered landmark type) of the selected item

View file

@ -87,7 +87,7 @@ bool CGroupSkills::parse (xmlNodePtr cur, CInterfaceGroup *parentGroup)
string sTmp; string sTmp;
ICDBNode::CTextId textId; ICDBNode::CTextId textId;
for (uint k = 0; k < SKILLS::NUM_SKILLS; ++k) for (uint k = 0; k < SKILLS::NUM_SKILLS; ++k)
{ {
sTmp = string(DB_SKILLS)+":"+NLMISC::toString((sint32)k)+":BaseSKILL"; sTmp = string(DB_SKILLS)+":"+NLMISC::toString((sint32)k)+":BaseSKILL";

View file

@ -378,13 +378,13 @@ void CGuildManager::update()
// Online status not changed for this member // Online status not changed for this member
continue; continue;
} }
if ( (*it).second.Online != ccs_offline && _GuildMembers[i].Online != ccs_offline) if ( (*it).second.Online != ccs_offline && _GuildMembers[i].Online != ccs_offline)
{ {
// Not from offline, or to offline, so don't show anything // Not from offline, or to offline, so don't show anything
continue; continue;
} }
ucstring msg = (_GuildMembers[i].Online != ccs_offline) ? onlineMessage : offlineMessage; ucstring msg = (_GuildMembers[i].Online != ccs_offline) ? onlineMessage : offlineMessage;
strFindReplace(msg, "%s", _GuildMembers[i].Name); strFindReplace(msg, "%s", _GuildMembers[i].Name);
string cat = getStringCategory(msg, msg); string cat = getStringCategory(msg, msg);
@ -398,7 +398,6 @@ void CGuildManager::update()
bool dummy; bool dummy;
PeopleInterraction.ChatInput.Guild.displayMessage(msg, col, 2, &dummy); PeopleInterraction.ChatInput.Guild.displayMessage(msg, col, 2, &dummy);
break; break;
} }
} }

View file

@ -3982,5 +3982,3 @@ bool CInterfaceManager::parseTokens(ucstring& ucstr)
ucstr = str; ucstr = str;
return true;; return true;;
} }

View file

@ -119,7 +119,7 @@ public:
char * end = ptr.getDatas() + strlen( ptr.getDatas() ); char * end = ptr.getDatas() + strlen( ptr.getDatas() );
char * dataTok = strtok( ptr.getDatas()," ,"); char * dataTok = strtok( ptr.getDatas()," ,");
NLMISC::ICDBNode::CTextId textId; NLMISC::ICDBNode::CTextId textId;
while(dataTok) while(dataTok)
{ {
std::string data (dataTok); std::string data (dataTok);

View file

@ -2193,7 +2193,6 @@ class CHandlerTellContact : public IActionHandler
CInterfaceGroup *ig = pCaller->getParent(); CInterfaceGroup *ig = pCaller->getParent();
if (!ig) return; if (!ig) return;
CGroupContainer *gc = static_cast< CGroupContainer* >( ig->getEnclosingContainer() ); CGroupContainer *gc = static_cast< CGroupContainer* >( ig->getEnclosingContainer() );
if (!gc) return; if (!gc) return;
CPeopleList *list; CPeopleList *list;
uint peopleIndex; uint peopleIndex;

View file

@ -895,7 +895,7 @@ class CHandlerContactEntry : public IActionHandler
// it is simpler to keep it as it and to just use this action handler to manage user input. // it is simpler to keep it as it and to just use this action handler to manage user input.
if (!pCaller || !pCaller->getParent()) return; if (!pCaller || !pCaller->getParent()) return;
CGroupContainer *gc = static_cast< CGroupContainer* >( pCaller->getParent()->getEnclosingContainer() ); CGroupContainer *gc = static_cast< CGroupContainer* >( pCaller->getParent()->getEnclosingContainer() );
// title gives the name of the player // title gives the name of the player
ucstring playerName = gc->getUCTitle(); ucstring playerName = gc->getUCTitle();

View file

@ -474,16 +474,16 @@ void CSPhraseManager::memorizePhrase(uint32 memoryLine, uint32 memorySlot, ui
} }
} }
void CSPhraseManager::selectMemoryLineDBalt(sint32 memoryLine) // ***************************************************************************
void CSPhraseManager::selectMemoryLineDB(sint32 memoryLine)
{ {
if(memoryLine<0) if(memoryLine<0)
memoryLine= -1; memoryLine= -1;
if(_SelectedMemoryDBalt!=memoryLine) if(_SelectedMemoryDB!=memoryLine)
{ {
_SelectedMemoryDBalt= memoryLine; _SelectedMemoryDB= memoryLine;
// since memory selection changes then must update all the DB and the Ctrl states // since memory selection changes then must update all the DB and the Ctrl states
updateMemoryDBAll(); updateMemoryDBAll();
updateAllMemoryCtrlState(); updateAllMemoryCtrlState();
updateAllMemoryCtrlRegenTickRange(); updateAllMemoryCtrlRegenTickRange();
@ -492,14 +492,14 @@ void CSPhraseManager::selectMemoryLineDBalt(sint32 memoryLine)
} }
} }
// *************************************************************************** void CSPhraseManager::selectMemoryLineDBalt(sint32 memoryLine)
void CSPhraseManager::selectMemoryLineDB(sint32 memoryLine)
{ {
if(memoryLine<0) if(memoryLine<0)
memoryLine= -1; memoryLine= -1;
if(_SelectedMemoryDB!=memoryLine)
if(_SelectedMemoryDBalt!=memoryLine)
{ {
_SelectedMemoryDB= memoryLine; _SelectedMemoryDBalt= memoryLine;
// since memory selection changes then must update all the DB and the Ctrl states // since memory selection changes then must update all the DB and the Ctrl states
updateMemoryDBAll(); updateMemoryDBAll();
updateAllMemoryCtrlState(); updateAllMemoryCtrlState();
@ -573,7 +573,7 @@ void CSPhraseManager::updateMemoryDBSlot(uint32 memorySlot)
_MemoryDbLeaves[memorySlot]->setValue32(0); _MemoryDbLeaves[memorySlot]->setValue32(0);
else else
_MemoryDbLeaves[memorySlot]->setValue32(slot.Id); _MemoryDbLeaves[memorySlot]->setValue32(slot.Id);
CMemorySlot &slotAlt= _Memories[_SelectedMemoryDBalt].Slot[memorySlot]; CMemorySlot &slotAlt= _Memories[_SelectedMemoryDBalt].Slot[memorySlot];
if(!slotAlt.isPhrase()) if(!slotAlt.isPhrase())
@ -1126,7 +1126,7 @@ void CSPhraseManager::buildPhraseDesc(ucstring &text, const CSPhraseCom &phrase,
uint32 totalActionMalus= 0; uint32 totalActionMalus= 0;
CCDBNodeLeaf *actMalus = _TotalMalusEquipLeaf ? &*_TotalMalusEquipLeaf CCDBNodeLeaf *actMalus = _TotalMalusEquipLeaf ? &*_TotalMalusEquipLeaf
: &*(_TotalMalusEquipLeaf = NLGUI::CDBManager::getInstance()->getDbProp("UI:VARIABLES:TOTAL_MALUS_EQUIP", false)); : &*(_TotalMalusEquipLeaf = NLGUI::CDBManager::getInstance()->getDbProp("UI:VARIABLES:TOTAL_MALUS_EQUIP", false));
// root brick must not be Power or aura, because Action malus don't apply to them // root brick must not be Power or aura, because Action malus don't apply to them
// (ie leave 0 ActionMalus for Aura or Powers // (ie leave 0 ActionMalus for Aura or Powers
if(actMalus && !rootBrick->isSpecialPower()) if(actMalus && !rootBrick->isSpecialPower())
@ -4519,7 +4519,7 @@ uint32 CSPhraseManager::getTotalActionMalus(const CSPhraseCom &phrase) const
if (!rootBrick) if (!rootBrick)
nlerror("Invalid root sbrick in sphrase_com '%s'", phrase.Name.toUtf8().c_str()); nlerror("Invalid root sbrick in sphrase_com '%s'", phrase.Name.toUtf8().c_str());
else if (actMalus && !rootBrick->isSpecialPower()) else if (actMalus && !rootBrick->isSpecialPower())
totalActionMalus = actMalus->getValue32(); totalActionMalus = actMalus->getValue32();
} }
return totalActionMalus; return totalActionMalus;
} }

View file

@ -106,11 +106,11 @@ enum TFilterMapping
// constructor // constructor
//----------------------------------------------- //-----------------------------------------------
CSoundManager::CSoundManager(IProgressCallback * /* progressCallBack */) CSoundManager::CSoundManager(IProgressCallback * /* progressCallBack */)
: _AudioMixer(NULL), : _AudioMixer(NULL),
_GroupControllerEffects(NULL), _GroupControllerEffects(NULL),
_GroupControllerEffectsGame(NULL), _GroupControllerEffectsGame(NULL),
_EnvSoundRoot(NULL), _EnvSoundRoot(NULL),
_Sources(NULL), _Sources(NULL),
_UserEntitySoundLevel(1.0f) _UserEntitySoundLevel(1.0f)
{ {
_EnableBackgroundMusicAtTime= 0; _EnableBackgroundMusicAtTime= 0;

View file

@ -518,7 +518,7 @@ void CUserEntity::updateVisualPropertyName(const NLMISC::TGameCycle &gameCycle,
html->browse("home"); html->browse("home");
} }
} }
*/ */
}// updateVisualPropertyName // }// updateVisualPropertyName //
//----------------------------------------------- //-----------------------------------------------

View file

@ -187,7 +187,7 @@ end
function strify(str) function strify(str)
return [["]] .. tostring(str) .. [["]] return [["]] .. tostring(str) .. [["]]
end end
------------------------------------------------------------------------------------------------- -------------------------------------------------------------------------------------------------
-- enclose a string by double quotes -- enclose a string by double quotes
function strifyXml(str) function strifyXml(str)

View file

@ -1112,7 +1112,7 @@
<PARAMETER NAME="faction/quantity" TYPE="string" VISIBLE="true"/> <PARAMETER NAME="faction/quantity" TYPE="string" VISIBLE="true"/>
<PARAMETER NAME="place" TYPE="string" VISIBLE="true"/> <PARAMETER NAME="place" TYPE="string" VISIBLE="true"/>
</PRIMITIVE> </PRIMITIVE>
<PRIMITIVE CLASS_NAME="talk_to" TYPE="node" PARENT_CLASS="objective_parent"> <PRIMITIVE CLASS_NAME="talk_to" TYPE="node" PARENT_CLASS="objective_parent">
<PARAMETER NAME="name" TYPE="string" VISIBLE="true" AUTONAME="talk_to $npc_name$"/> <PARAMETER NAME="name" TYPE="string" VISIBLE="true" AUTONAME="talk_to $npc_name$"/>
<!-- talk to param--> <!-- talk to param-->
@ -1126,7 +1126,7 @@
<PARAMETER NAME="name" TYPE="string" VISIBLE="true" AUTONAME="cast $spell$"/> <PARAMETER NAME="name" TYPE="string" VISIBLE="true" AUTONAME="cast $spell$"/>
<PARAMETER NAME="action" TYPE="string_array" VISIBLE="true"/> <PARAMETER NAME="action" TYPE="string_array" VISIBLE="true"/>
<PARAMETER NAME="place" TYPE="string" VISIBLE="true"/> <PARAMETER NAME="place" TYPE="string" VISIBLE="true"/>
</PRIMITIVE> </PRIMITIVE>
<PRIMITIVE CLASS_NAME="forage" TYPE="node" PARENT_CLASS="objective_parent"> <PRIMITIVE CLASS_NAME="forage" TYPE="node" PARENT_CLASS="objective_parent">
@ -5023,13 +5023,13 @@
</PARAMETER> </PARAMETER>
<PARAMETER NAME="entity id" TYPE="string" VISIBLE="true" READ_ONLY="true"> <PARAMETER NAME="entity id" TYPE="string" VISIBLE="true" READ_ONLY="true">
</PARAMETER> </PARAMETER>
<PARAMETER NAME= "Sheet" TYPE="string" READ_ONLY="true" VISIBLE="true"> <PARAMETER NAME= "Sheet" TYPE="string" READ_ONLY="true" VISIBLE="true">
<DEFAULT_VALUE VALUE="unknown"/> <DEFAULT_VALUE VALUE="unknown"/>
</PARAMETER> </PARAMETER>
<PARAMETER NAME= "HitPoints" TYPE="string" READ_ONLY="true" VISIBLE="true"> <PARAMETER NAME= "HitPoints" TYPE="string" READ_ONLY="true" VISIBLE="true">
<DEFAULT_VALUE VALUE="0"/> <DEFAULT_VALUE VALUE="0"/>
</PARAMETER> </PARAMETER>
<PARAMETER NAME= "MaxHitPoints" TYPE="string" READ_ONLY="true" VISIBLE="true"> <PARAMETER NAME= "MaxHitPoints" TYPE="string" READ_ONLY="true" VISIBLE="true">
<DEFAULT_VALUE VALUE="0"/> <DEFAULT_VALUE VALUE="0"/>
</PARAMETER> </PARAMETER>
<PARAMETER NAME= "Mode" TYPE="string" READ_ONLY="true" VISIBLE="true"> <PARAMETER NAME= "Mode" TYPE="string" READ_ONLY="true" VISIBLE="true">