From 82e835cd5964437b6c4169967ca69b46a56d121a Mon Sep 17 00:00:00 2001 From: kervala Date: Fri, 11 Dec 2015 20:16:06 +0100 Subject: [PATCH 1/3] Changed: Append _dev to client if compiling without FINAL_VERSION (like Nevrax did) --- code/ryzom/client/src/CMakeLists.txt | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/code/ryzom/client/src/CMakeLists.txt b/code/ryzom/client/src/CMakeLists.txt index 73122cb64..2a5b1c175 100644 --- a/code/ryzom/client/src/CMakeLists.txt +++ b/code/ryzom/client/src/CMakeLists.txt @@ -117,7 +117,15 @@ ADD_DEFINITIONS(${LIBXML2_DEFINITIONS} ${CURL_DEFINITIONS} ${LUABIND_DEFINITIONS NL_DEFAULT_PROPS(ryzom_client "Ryzom, Client: Ryzom Core Client") NL_ADD_RUNTIME_FLAGS(ryzom_client) -NL_ADD_LIB_SUFFIX(ryzom_client) +IF(FINAL_VERSION) + NL_ADD_LIB_SUFFIX(ryzom_client) +ELSE() + IF(WIN32) + SET_TARGET_PROPERTIES(ryzom_client PROPERTIES DEBUG_POSTFIX "_dev_d" RELEASE_POSTFIX "_dev_r") + ELSE() + SET_TARGET_PROPERTIES(ryzom_client PROPERTIES POSTFIX "_dev") + ENDIF() +ENDIF() IF(WITH_RYZOM_CLIENT_UAC) IF(CMAKE_GENERATOR MATCHES "Visual Studio") From ab584867f584de179a4c61a997b1b08ab79d38f2 Mon Sep 17 00:00:00 2001 From: kervala Date: Fri, 11 Dec 2015 20:19:10 +0100 Subject: [PATCH 2/3] Fixed: OS X uses .dylib extension instead of .so --- code/nel/include/nel/misc/dynloadlib.h | 3 ++- code/nel/include/nel/net/module_manager.h | 2 +- code/nel/src/misc/dynloadlib.cpp | 3 +++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/code/nel/include/nel/misc/dynloadlib.h b/code/nel/include/nel/misc/dynloadlib.h index a42dbf067..63719f423 100644 --- a/code/nel/include/nel/misc/dynloadlib.h +++ b/code/nel/include/nel/misc/dynloadlib.h @@ -174,7 +174,8 @@ public: /** Build a NeL standard library name according to platform and compilation mode setting. * aka : adding decoration one base lib name. - * e.g : 'mylib' become 'mylib_rd.dll' on Windows ReleaseDebug mode or + * e.g : 'mylib' become 'mylib_rd.dll' on Windows ReleaseDebug mode, + * 'libmylib.dylib' under OS X or * 'libmylib.so' on unix system. */ static std::string makeLibName(const std::string &baseName); diff --git a/code/nel/include/nel/net/module_manager.h b/code/nel/include/nel/net/module_manager.h index e4c23f8b6..92f947f74 100644 --- a/code/nel/include/nel/net/module_manager.h +++ b/code/nel/include/nel/net/module_manager.h @@ -70,7 +70,7 @@ namespace NLNET * * The library name is the base name that will be 'decorated' * with the nel naming standard according to compilation mode - * and platform specific file extension (.dll or .so). + * and platform specific file extension (.dll, .dylib or .so). * * A module library can only be loaded once. If the library * is already loaded, the call is ingored. diff --git a/code/nel/src/misc/dynloadlib.cpp b/code/nel/src/misc/dynloadlib.cpp index 25f28286e..0b456f166 100644 --- a/code/nel/src/misc/dynloadlib.cpp +++ b/code/nel/src/misc/dynloadlib.cpp @@ -71,6 +71,9 @@ void *nlGetSymbolAddress(NL_LIB_HANDLE libHandle, const std::string &procName) #ifdef NL_OS_WINDOWS const string nlLibPrefix; // empty const string nlLibExt(".dll"); +#elif defined(NL_OS_MAC) + const string nlLibPrefix("lib"); + const string nlLibExt(".dylib"); #elif defined(NL_OS_UNIX) const string nlLibPrefix("lib"); const string nlLibExt(".so"); From 0f9bd76e636b24c628f507f5f2f2353de97f0be9 Mon Sep 17 00:00:00 2001 From: kervala Date: Fri, 11 Dec 2015 20:21:17 +0100 Subject: [PATCH 3/3] Changed: Sort dictionary keys --- code/ryzom/client/macosx/Info.plist | 36 ++++++++++++++++------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/code/ryzom/client/macosx/Info.plist b/code/ryzom/client/macosx/Info.plist index 199996f07..9bb1fdbe0 100644 --- a/code/ryzom/client/macosx/Info.plist +++ b/code/ryzom/client/macosx/Info.plist @@ -14,6 +14,14 @@ ${MACOSX_BUNDLE_GUI_IDENTIFIER} CFBundleInfoDictionaryVersion 6.0 + CFBundleLocalizations + + en + fr + de + ru + es + CFBundleLongVersionString ${MACOSX_BUNDLE_LONG_VERSION_STRING} CFBundleName @@ -24,27 +32,23 @@ ${MACOSX_BUNDLE_SHORT_VERSION_STRING} CFBundleSignature ???? + CFBundleSupportedPlatforms + + MacOSX + CFBundleVersion ${MACOSX_BUNDLE_BUNDLE_VERSION} - NSHumanReadableCopyright - ${MACOSX_BUNDLE_COPYRIGHT} - LSMinimumSystemVersion - ${CMAKE_OSX_DEPLOYMENT_TARGET} - LSFileQuarantineEnabled - CSResourcesFileMapped - LSRequiresCarbon - - CFBundleLocalizations - - en - fr - de - ru - es - LSApplicationCategoryType public.app-category.role-playing-games + LSFileQuarantineEnabled + + LSMinimumSystemVersion + ${CMAKE_OSX_DEPLOYMENT_TARGET} + LSRequiresCarbon + + NSHumanReadableCopyright + ${MACOSX_BUNDLE_COPYRIGHT}